Web SDK Refactor: Operation Repo Rework#1264
Merged
Merged
Conversation
sherwinski
approved these changes
Apr 14, 2025
| const OP_REPO_EXECUTION_INTERVAL = 5000; | ||
| const OP_REPO_POST_CREATE_RETRY_UP_TO = 60_000; | ||
|
|
||
| export class NewRecordsState { |
Contributor
There was a problem hiding this comment.
Let's add a comment to refer to the NewRecordsState file in the android SDK. Either that, or copy the source-level comments from the file.
I would recommend doing this for each of the classes/functions you've defined below as makes it easier to understand the individual components more easily.
Contributor
Author
There was a problem hiding this comment.
I'll add references to those.
| let highestRetries = 0; | ||
| switch (response.result) { | ||
| case ExecutionResult.Success: | ||
| // Remove operations from store and wake waiters |
Contributor
There was a problem hiding this comment.
We should update this comment if we're not using waiters
| } catch (e) { | ||
| Log.error(`Error attempting to execute operation: ${ops}`, e); | ||
|
|
||
| // On failure remove operations from store and wake waiters |
Contributor
There was a problem hiding this comment.
same comment here about clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the start of the Web SDK rework which can be read here.
With the goal of solving issues with having correct commands (addTag) apply to the correct user (login) in the right order.
This pr focuses on porting on the Android SDK OperationRepo Class to typescript.
1 Line Summary
Details
Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is